[#PROACTIVE-673] GCMD Descriptors: user.dir != user.home - ProActive

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 4.1.1
Component/s: GCM Deployment

Description:

Hide
user.dir is wrongly used to describe the home directory of the user in many GCM Deployment Descriptors.

user.dir is the CWD.
user.home is the home directory.

[cmathieu@britany:programming-git]$ grep -R user.dir examples/
examples/nas/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/integralPi/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/montecarlo/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/benchLog4j/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/benchLog4j/GCMD.xml: <javaPropertyVariable name="user.dir" />
examples/benchLog4j/GCMD.xml: <homeDirectory base="root" relpath="${user.dir}" />
examples/jacobi/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/hello/helloDeploymentRemote.xml: <javaPropertyVariable name="user.dir" />
examples/hello/helloDeploymentRemote.xml: <homeDirectory base="root" relpath="${user.dir}" />
examples/hello/helloApplication.xml: <javaPropertyVariable name="user.dir" />
examples/penguin/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/timit/descriptors/TimItApplication.xml: <javaPropertyVariable name="user.dir" />
examples/timit/descriptors/TimItDeployment.xml: <javaPropertyVariable name="user.dir" />
examples/timit/descriptors/TimItDeployment.xml: <homeDirectory base="root" relpath="${user.dir}" />
examples/scilab/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
examples/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
examples/robustarith/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/flowshop/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/masterworker/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/c3d/GCMA_Renderer.xml: <javaPropertyVariable name="user.dir" />
examples/c3d/GCMA_User.xml: <javaPropertyVariable name="user.dir" />
examples/jacobiMPI/MPI-descriptor.xml: <relativePath origin="user.dir"
examples/matrix/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/agent/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/nbody/GCMA.xml: <javaPropertyVariable name="user.dir" />
examples/nbody/GCMA_FaultTolerance.xml: <javaPropertyVariable name="user.dir" />

[cmathieu@britany:programming-git]$ grep -R user.dir descriptors/
descriptors/examples/gcmd/grid5000Deployment.xml: <homeDirectory base="root" relpath="${user.dir}" />

[cmathieu@britany:programming-git]$ grep -R user.dir src/
src/Examples/org/objectweb/proactive/examples/jacobi/Jacobi.java: File resultFile = new File(System.getProperty("user.dir") + File.separator + resultsFileName);
src/Examples/org/objectweb/proactive/examples/pi/descriptors/applicationDescriptor.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/pi/descriptors/deploymentLocal.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/pi/descriptors/deploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/components/userguide/starter/applicationDescriptor.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMA.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Examples/org/objectweb/proactive/examples/masterworker/MWApplication.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/masterworker/GCMD_Local.xml: <javaPropertyVariable name="user.dir" />
src/Examples/org/objectweb/proactive/examples/masterworker/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersDeploymentLocal.xml: <javaPropertyVariable name="user.dir" />
src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersDeploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" />
src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersApplication.xml: <javaPropertyVariable name="user.dir" />
src/Tests/functionalTests/runtime/classloader/Test.java: File userDir = new File(System.getProperty("user.dir"));
src/Tests/functionalTests/descriptor/extendedjvm/Test.java: File userDir = new File(System.getProperty("user.dir"));
src/Tests/functionalTests/descriptor/variablecontract/javaproperties/Test.java: variableContract.setDescriptorVariable("user.dir", "", VariableContractType
src/Tests/functionalTests/descriptor/variablecontract/javaproperties/Test.java: Assert.assertEquals(System.getProperty("user.dir"), variableContract.getValue("user.dir"));
src/Core/org/objectweb/proactive/core/xml/VariableContractImpl.java: logger.debug("Curret Working Directory: " + System.getProperty("user.dir"));
src/Core/org/objectweb/proactive/core/descriptor/legacyparser/PathHandler.java: private static final String WORKING_DIRECTORY_ORIGIN = "user.dir";
src/Core/org/objectweb/proactive/core/descriptor/legacyparser/PathHandler.java: private static final String userDir = System.getProperty("user.dir");
src/Core/org/objectweb/proactive/core/descriptor/xml/schemas/deployment/3.3/deployment.xsd: <xs:enumeration value="user.dir" />
src/Core/org/objectweb/proactive/core/descriptor/parser/JaxpDescriptorParser.java: private static final String WORKING_DIRECTORY_ORIGIN = "user.dir";
src/Core/org/objectweb/proactive/core/descriptor/parser/JaxpDescriptorParser.java: private static final String userDir = System.getProperty("user.dir");
src/Extensions/org/objectweb/proactive/extensions/webservices/WebServices.java: "Failed to create a temporary Service Store, " + System.getProperty("user.dir") +
src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentApplication.xml: <javaPropertyVariable name="user.dir" />
src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentDeploymentLocal.xml: <javaPropertyVariable name="user.dir" />
src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentDeploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" />

Show
user.dir is wrongly used to describe the home directory of the user in many GCM Deployment Descriptors. user.dir is the CWD. user.home is the home directory. [cmathieu@britany:programming-git]$ grep -R user.dir examples/ examples/nas/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/integralPi/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/montecarlo/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/benchLog4j/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/benchLog4j/GCMD.xml: <javaPropertyVariable name="user.dir" /> examples/benchLog4j/GCMD.xml: <homeDirectory base="root" relpath="${user.dir}" /> examples/jacobi/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/hello/helloDeploymentRemote.xml: <javaPropertyVariable name="user.dir" /> examples/hello/helloDeploymentRemote.xml: <homeDirectory base="root" relpath="${user.dir}" /> examples/hello/helloApplication.xml: <javaPropertyVariable name="user.dir" /> examples/penguin/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/timit/descriptors/TimItApplication.xml: <javaPropertyVariable name="user.dir" /> examples/timit/descriptors/TimItDeployment.xml: <javaPropertyVariable name="user.dir" /> examples/timit/descriptors/TimItDeployment.xml: <homeDirectory base="root" relpath="${user.dir}" /> examples/scilab/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> examples/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> examples/robustarith/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/flowshop/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/masterworker/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/c3d/GCMA_Renderer.xml: <javaPropertyVariable name="user.dir" /> examples/c3d/GCMA_User.xml: <javaPropertyVariable name="user.dir" /> examples/jacobiMPI/MPI-descriptor.xml: <relativePath origin="user.dir" examples/matrix/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/agent/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/nbody/GCMA.xml: <javaPropertyVariable name="user.dir" /> examples/nbody/GCMA_FaultTolerance.xml: <javaPropertyVariable name="user.dir" /> [cmathieu@britany:programming-git]$ grep -R user.dir descriptors/ descriptors/examples/gcmd/grid5000Deployment.xml: <homeDirectory base="root" relpath="${user.dir}" /> [cmathieu@britany:programming-git]$ grep -R user.dir src/ src/Examples/org/objectweb/proactive/examples/jacobi/Jacobi.java: File resultFile = new File(System.getProperty("user.dir") + File.separator + resultsFileName); src/Examples/org/objectweb/proactive/examples/pi/descriptors/applicationDescriptor.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/pi/descriptors/deploymentLocal.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/pi/descriptors/deploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/components/userguide/starter/applicationDescriptor.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/deployed/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/migration/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/synch/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/cmagent/groups/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributed/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMA.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/userguide/primes/distributedmw/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Examples/org/objectweb/proactive/examples/masterworker/MWApplication.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/masterworker/GCMD_Local.xml: <javaPropertyVariable name="user.dir" /> src/Examples/org/objectweb/proactive/examples/masterworker/GCMD_Local.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersDeploymentLocal.xml: <javaPropertyVariable name="user.dir" /> src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersDeploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" /> src/Extra/org/objectweb/proactive/extra/montecarlo/example/WorkersApplication.xml: <javaPropertyVariable name="user.dir" /> src/Tests/functionalTests/runtime/classloader/Test.java: File userDir = new File(System.getProperty("user.dir")); src/Tests/functionalTests/descriptor/extendedjvm/Test.java: File userDir = new File(System.getProperty("user.dir")); src/Tests/functionalTests/descriptor/variablecontract/javaproperties/Test.java: variableContract.setDescriptorVariable("user.dir", "", VariableContractType src/Tests/functionalTests/descriptor/variablecontract/javaproperties/Test.java: Assert.assertEquals(System.getProperty("user.dir"), variableContract.getValue("user.dir")); src/Core/org/objectweb/proactive/core/xml/VariableContractImpl.java: logger.debug("Curret Working Directory: " + System.getProperty("user.dir")); src/Core/org/objectweb/proactive/core/descriptor/legacyparser/PathHandler.java: private static final String WORKING_DIRECTORY_ORIGIN = "user.dir"; src/Core/org/objectweb/proactive/core/descriptor/legacyparser/PathHandler.java: private static final String userDir = System.getProperty("user.dir"); src/Core/org/objectweb/proactive/core/descriptor/xml/schemas/deployment/3.3/deployment.xsd: <xs:enumeration value="user.dir" /> src/Core/org/objectweb/proactive/core/descriptor/parser/JaxpDescriptorParser.java: private static final String WORKING_DIRECTORY_ORIGIN = "user.dir"; src/Core/org/objectweb/proactive/core/descriptor/parser/JaxpDescriptorParser.java: private static final String userDir = System.getProperty("user.dir"); src/Extensions/org/objectweb/proactive/extensions/webservices/WebServices.java: "Failed to create a temporary Service Store, " + System.getProperty("user.dir") + src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentApplication.xml: <javaPropertyVariable name="user.dir" /> src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentDeploymentLocal.xml: <javaPropertyVariable name="user.dir" /> src/Extensions/org/objectweb/proactive/extensions/calcium/examples/GCMEnvironmentDeploymentLocal.xml: <homeDirectory base="root" relpath="${user.dir}" />

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Clement Mathieu added a comment - 18/May/09 6:14 PM

Fixed.

Should be backported to 4.0.4 and 4.1.1. I hope the 4.0.4 backport will not generate too many conflicts.

Show

Clement Mathieu added a comment - 18/May/09 6:14 PM Fixed. Should be backported to 4.0.4 and 4.1.1. I hope the 4.0.4 backport will not generate too many conflicts.

Hide

Permalink

Clement Mathieu added a comment - 22/May/09 3:59 PM

Merged in 4.1.1

Show

Clement Mathieu added a comment - 22/May/09 3:59 PM Merged in 4.1.1

People

Assignee:

Clement Mathieu

Reporter:

Clement Mathieu
Votes:

0

Watchers:

1

Dates

Created:

18/May/09 5:27 PM

Updated:

18/Aug/10 4:06 PM

Resolved:

18/May/09 6:14 PM

ProActive Programming

GCMD Descriptors: user.dir != user.home

Details

Activity

People

Dates