ProActive Programming

PBS support broken due to bad escaping

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 4.1.0
  • Fix Version/s: 4.1.1
  • Component/s: GCM Deployment
  • Description:
    Hide
    PBS support is broken since the 2008 Dec 8 due to a bad escaping. This line "command = command.replaceAll("'", "\"");" has been added by the merge of the debugger branch. It breaks at least the PBS support. I assume that LSF, OAR, SGE are also impacted.

    This line must be removed

      
    commit a217ab424bcb18902fb01e05afe693261d68e361
    Author: acontes <acontes@28e8926c-6b08-0410-baaa-805c5e19b8d6>
    Date: Tue Dec 16 14:31:46 2008 +0000

        added new GCMA tag <debug/> to start a runtime with the debug options
        
        git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/proactive/trunk@10830 28e8926c-6b08-0410-baaa-805c5e19b8d6

    diff --git a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    index 0519161..52f5675 100644
    --- a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    +++ b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    @@ -60,16 +60,10 @@ public class Executor {
             return singleton;
         }
     
    - private String addDebugInCommand(String command) {
    - String debugCommand = command.replaceAll("[$]DBGID[$]", "debuggee_port" + jobId);
    - return debugCommand;
    - }
    -
         public void submit(String command) {
             Logger logger = ProActiveLogger.getLogger(Loggers.DEPLOYMENT + ".job." + jobId);
             jobId++;
     
    - command = addDebugInCommand(command);
             command = command.replaceAll("'", "\"");
             logger.debug("Command submited: " + command);
             try {

    commit 56decb05a057a1dc888a7da3d23d6e89f28318ef
    Author: acontes <acontes@28e8926c-6b08-0410-baaa-805c5e19b8d6>
    Date: Mon Dec 8 10:38:32 2008 +0000

        - initial import of the debugger feature
        
        git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/proactive/trunk@10737 28e8926c-6b08-0410-baaa-805c5e19b8d6

    diff --git a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    index f569024..0519161 100644
    --- a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    +++ b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java
    @@ -60,10 +60,17 @@ public class Executor {
             return singleton;
         }
     
    + private String addDebugInCommand(String command) {
    + String debugCommand = command.replaceAll("[$]DBGID[$]", "debuggee_port" + jobId);
    + return debugCommand;
    + }
    +
         public void submit(String command) {
             Logger logger = ProActiveLogger.getLogger(Loggers.DEPLOYMENT + ".job." + jobId);
             jobId++;
     
    + command = addDebugInCommand(command);
    + command = command.replaceAll("'", "\"");
             logger.debug("Command submited: " + command);
             try {
                 System.out.println("executing command=" + command);
    Show
    PBS support is broken since the 2008 Dec 8 due to a bad escaping. This line "command = command.replaceAll("'", "\"");" has been added by the merge of the debugger branch. It breaks at least the PBS support. I assume that LSF, OAR, SGE are also impacted. This line must be removed    commit a217ab424bcb18902fb01e05afe693261d68e361 Author: acontes <acontes@28e8926c-6b08-0410-baaa-805c5e19b8d6> Date: Tue Dec 16 14:31:46 2008 +0000     added new GCMA tag <debug/> to start a runtime with the debug options          git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/proactive/trunk@10830 28e8926c-6b08-0410-baaa-805c5e19b8d6 diff --git a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java index 0519161..52f5675 100644 --- a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java +++ b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java @@ -60,16 +60,10 @@ public class Executor {          return singleton;      }   - private String addDebugInCommand(String command) { - String debugCommand = command.replaceAll("[$]DBGID[$]", "debuggee_port" + jobId); - return debugCommand; - } -      public void submit(String command) {          Logger logger = ProActiveLogger.getLogger(Loggers.DEPLOYMENT + ".job." + jobId);          jobId++;   - command = addDebugInCommand(command);          command = command.replaceAll("'", "\"");          logger.debug("Command submited: " + command);          try { commit 56decb05a057a1dc888a7da3d23d6e89f28318ef Author: acontes <acontes@28e8926c-6b08-0410-baaa-805c5e19b8d6> Date: Mon Dec 8 10:38:32 2008 +0000     - initial import of the debugger feature          git-svn-id: svn+ssh://scm.gforge.inria.fr/svn/proactive/trunk@10737 28e8926c-6b08-0410-baaa-805c5e19b8d6 diff --git a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java index f569024..0519161 100644 --- a/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java +++ b/src/Extensions/org/objectweb/proactive/extensions/gcmdeployment/GCMDeployment/Executor.java @@ -60,10 +60,17 @@ public class Executor {          return singleton;      }   + private String addDebugInCommand(String command) { + String debugCommand = command.replaceAll("[$]DBGID[$]", "debuggee_port" + jobId); + return debugCommand; + } +      public void submit(String command) {          Logger logger = ProActiveLogger.getLogger(Loggers.DEPLOYMENT + ".job." + jobId);          jobId++;   + command = addDebugInCommand(command); + command = command.replaceAll("'", "\"");          logger.debug("Command submited: " + command);          try {              System.out.println("executing command=" + command);

Activity

Hide
Clement Mathieu added a comment - 02/Jun/09 4:25 PM
Merged in 4.1.1
Show
Clement Mathieu added a comment - 02/Jun/09 4:25 PM Merged in 4.1.1

People

Dates

  • Created:
    27/May/09 4:52 PM
    Updated:
    02/Jun/09 4:25 PM
    Resolved:
    27/May/09 5:22 PM